I see some favourites are already mentioned: HK47, Legion, Wrex, Elizabeth (whatever the criticism, I thought Bioshock Infinite was an outstanding game), Mordin.
Also want to add Taimi from guild wars 2 - her voice actor and dialogue is excellent, often has me cracking up laughing.