[MOD] More Realistic Combat Animations and Half-swording

[Triangle]

From my experience modding for this game, a cheat that takes 1 minute of changing one line or a stolen project will get it far more attention than what takes you weeks or months of hard work. Look at the (barely) attention that this thread or my sounds tool got.

Any major work that I do will be part of School of the Roach, which is the way I actually play the game (I'm modding for myself first and foremost).
The work is public though, so if people really want it, they can strip it from SOTR and implement it to their own set of mods, although you will have to do that on your own.

Make a new branch (if you haven't already) on whatever public version control you use for SOTR and post the link. Then people can see just the changes you make for these animations, and you don't have to package a separate mod. easy!

EDIT - speaking of which, is there a SOTR github repo we can check out? I don't see a link anywhere

The issue is that it's extremely difficult to find the changes for a particular aspect of the mod. I'm looking at the SOTR scripts right now and it's not even consistently marked internally. Some things have comments like `modSOTR_bolts` but it doesn't seem common, and is often inconsistent. And that's just the scripts, I don't know if you had to make changes outside that, as well. And in any case, the scripts are prob the easiest part of this mod! Looks like you labored hard for it.

Would love to know what the necessary files are at least (and for *.ws scripts, what parts), so we can rip it out of SOTR. I figure we need the single w2anim file in modSOTR_Animations, and the custom animation events in `playerWitcher.ws`, but is there anything else?

 

[Yog-Sothoth88]

Those comments are left overs from the original team who worked on SOTR before me. I don't add comments because SOTR isn't supposed to be merged into other mods.

As for what you need:

The combo aspects from CombatSword.
Applying the aspects and ADIST_Small to combos in Combat.
A method that controls Geralt's animation speed (SOTR uses W3PlayerWitcher::UpdateSpeed).
The same animation speed control method to be hooked to the combat action (SOTR hooks into CPlayer::SetBIsInCombatAction).
Custom event callbacks to increase the animation speed for those custom animations.

 

[Triangle]

Thanks, I'll go ahead and diff CombatSword.ws, Combat.ws, player.ws, and playerWitcher.ws sometime this week, if that's all the files you edited. Although I have my own system for changing animation speeds, so it'll be a little different. I'll prob ask for more clarification later, since I'm sure that are buttloads of changes to those files.

Are there any other non-script files besides the one in modSOTR_Animations?

Btw, who works on SOTR now? Didn't a lot of people drop off (as usual for group mods...)? And do you have a public repo anywhere?

sidenote: I'm the only one working on my mod, but I've found it super helpful to tag what changes belong to what feature. It's especially nice for refactors, patch merges, etc, since I know exactly what feature I'm touching when I resolve a conflict, and what is/isn't vanilla code. Esp useful when I realize a feature is buggy long after I implement it, and need to find all the relevant bits of code quickly. I take really long breaks since I don't have tons of time to work on it, so it helps there too. FYI, anyways.

 

[Yog-Sothoth88]

Only man_geralt_sword.w2anims was changed outside of the scripts; Although that file alone was what took me a whole week of non-stop work.

Also, I do not need comments if I don't expect people to go through my codes, as I've a photographic-like memory (not a true photographic memory but close).

As for SOTR, I'm the only person working on it since it was abandoned late last year/early this year.
At this point however, it's pretty much a different mod from the one that was abandoned (a mod littered with bugs and unfinished stuff).
I don't have a public repository as the lastest version of SOTR is always the version I'm playing, so I just change things on the fly and test them.

 

[Triangle]

Hey, finally got around to this. Thanks for putting in the effort wrt the w2anims file! And thank for posting. I would have never noticed it otherwise. Haven't decided if I'll actually end up using it, though. For anyone else trying to incorporate the custom animations, all the script changes I did are in this commit: https://github.com/TriangleAuthority/TriangleMod/commit/405a7f009b6f1f8a6ca5bf5257d948d7d39ccfa0 EDIT: some of these changes are specific to how I do things, eg animation speed changes, so they wont apply to everyone.

 

[Cyfa]

Hey, finally got around to this. Thanks for putting in the effort wrt the w2anims file! And thank for posting. I would have never noticed it otherwise. Haven't decided if I'll actually end up using it, though. For anyone else trying to incorporate the custom animations, all the script changes I did are in this commit: https://github.com/TriangleAuthority/TriangleMod/commit/405a7f009b6f1f8a6ca5bf5257d948d7d39ccfa0 EDIT: some of these changes are specific to how I do things, eg animation speed changes, so they wont apply to everyone.

Hey man, thanks for isolating the files. For some reason it keeps giving me script errors when I try and use your files (the ones that are marked for the proper animations, that is.) I'm going to mess around a bit and see if I can fix it, I assume it's probably because I didn't get the correct w2anims file.

 

[Triangle]

Hey man, thanks for isolating the files. For some reason it keeps giving me script errors when I try and use your files (the ones that are marked for the proper animations, that is.) I'm going to mess around a bit and see if I can fix it, I assume it's probably because I didn't get the correct w2anims file.

The changes I made are partly specific to my mod, menus, etc. You'll have to adapt it to your own scripts. Check out School of the Roach, and compare it to what I have. That'll help you figure out what to pull from SotR to make the animations work. The main differences are: 1) how we change animation speed and 2) Custom menu options.

Also, note that there was a little bug fixed in this commit: https://github.com/TriangleAuthority/TriangleMod/commit/e39f77fbfcccfc3b986901b3e8dc2a2034f614be it's specific to the menus I use, though, so prob doesn't affect you.

 

[Cyfa]

The changes I made are partly specific to my mod, menus, etc. You'll have to adapt it to your own scripts. Check out School of the Roach, and compare it to what I have. That'll help you figure out what to pull from SotR to make the animations work. The main differences are: 1) how we change animation speed and 2) Custom menu options.

Also, note that there was a little bug fixed in this commit: https://github.com/TriangleAuthority/TriangleMod/commit/e39f77fbfcccfc3b986901b3e8dc2a2034f614be it's specific to the menus I use, though, so prob doesn't affect you.

Thanks for the response. I'll try doing that. If it doesn't workout, maybe I'll just play your mod

 

[Cercaphus]

Very interesting thread!

 

[crumplewiltspin]

Thanks for the response. I'll try doing that. If it doesn't workout, maybe I'll just play your mod

Did you figure it out? If not how's that dude's mod?
* z *

 

[spectreg57]

I like it! Always wanted more options for combat movement.

 

[Vidukind]

[MOD] More Realistic Combat Animations and Half-swording

Hello. I am a longtime fan of the School of the Roach, played the game with this mod many times. I am very accustomed to exactly these animations of the witcher fight without endless vanilla spins. Please tell me if it is possible to download these edits somewhere separately from the School of the Roach?
My question is related to the fact that this wonderful mod for this great game over the past years has somewhat tired, and I would like to experiment with other mods, and even just remember the original game. But when I see these ridiculous jumps of the witcher around himself in vanilla, longing seizes. Or are these edits available only to cool programmers, but not to ordinary users? Thanks.

Post automatically merged: Oct 9, 2020

Updated the original post with a video showing the speed boosts on the added animations.

Look at how Geralt is far more efficient without that spinning stupidity, and this is with animations that weren't even designed for him.
And to think that some people go to great lengths to defend spinning...

I do hope that CD Projekt Red takes some notes and if they do make another The Witcher game, they ignore Sapkowski's ignorance on martial arts and actually do proper animations for Geralt.
The real reason for me to work on this was because it was either no spinning or uninstall the game.

I fully share your views on the combat system in this series of games.

 

[Barebius]

Hi! Since you're the first person speaking about taking spear's animations - can you make a standalone mod allowing player to use spears? Nothing fency, just standart NPC's animations, increased range and block\parry?

 

[Vidukind]

It's a shame when the author of the best modification to "The Witcher 3" of all the countless mods for this game, for some reason, deletes his videos from YouTube. As if they were interfering with someone. Although, in fact, it is precisely these edits of fighting movements that are the best and most valuable component of the School of the Roach...

 

[Vidukind]

Hey, finally got around to this. Thanks for putting in the effort wrt the w2anims file! And thank for posting. I would have never noticed it otherwise. Haven't decided if I'll actually end up using it, though. For anyone else trying to incorporate the custom animations, all the script changes I did are in this commit: https://github.com/TriangleAuthority/TriangleMod/commit/405a7f009b6f1f8a6ca5bf5257d948d7d39ccfa0 EDIT: some of these changes are specific to how I do things, eg animation speed changes, so they wont apply to everyone.

Hello. Tell me, please, how can you download these wonderful edits of fencing separately from the School of the Roach? When I follow your link to github.com, nothing is clear there, unfortunately. Thanks